Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(com.google.android.apps.messaging): add notice for Unihertz users #684

Conversation

AnonymousWP
Copy link
Member

No description provided.

@AnonymousWP AnonymousWP added the package::documentation Improve a description/recommendation label Oct 5, 2024
Copy link
Contributor

deepsource-io bot commented Oct 5, 2024

Here's the code health analysis summary for commits 4541552..182e803. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@schbrns
Copy link

schbrns commented Oct 26, 2024

Is this really an issue? Those phones are bricks as far as I can read, Verizon Unihertz phones can't even SMS/MMS anymore.

@AnonymousWP
Copy link
Member Author

Is this really an issue? Those phones are bricks as far as I can read, Verizon Unihertz phones can't even SMS/MMS anymore.

Well, looking to the linked issue, it apparently is. It's not really an issue for all users, which is why removal remains the same but an additional note is added for Unihertz users. The fact that those Unihertz phones are quickly bricking is an issue apart from that in my opinion.

@schbrns
Copy link

schbrns commented Oct 27, 2024

Messages has been due for an upgrade to Expert, along with everything else I've been targeting.

Messages, historically, has affected: Banking verification, receiving SMS OTP, RCS capabilities, etc.

Wouldn't need anymore device-specific notes anymore then.

@AnonymousWP
Copy link
Member Author

Messages has been due for an upgrade to Expert, along with everything else I've been targeting.

Messages, historically, has affected: Banking verification, receiving SMS OTP, RCS capabilities, etc.

Wouldn't need anymore device-specific notes anymore then.

I believe using another SMS app should work, but I think this depends on the OEM (not sure). The note is merely important because of this:

Reinstalling does not fix the problem. Factory reset fixes it.

But feel free to open a PR (and/or issue where we can discuss this).

@schbrns
Copy link

schbrns commented Oct 28, 2024

I hear what you're saying when you say I should open a PR to discuss it but I'll save us both the time and provide it right here, along with justification.

Jutification:
Simply the REMOVAL AND REINSTALLATION of Messages,
breaks CORE FUNCTIONALITY on MOST CARRIERS/OEMS GLOBALLY,
to the point of needing A FACTORY RESET,
and the only workaround is to KEEP IT INSTALLED (REMOVAL: UNSAFE???),
alongside a different SMS app that you use.

"description": "Google Messages (https://play.google.com/store/apps/details?id=com.google.android.apps.messaging)\nSMS and RCS app.\nNOTE: Possibly a global dependency for SMS, MMS, RCS, OTP, and other services/verifications.\nWARNING: Once disabled/uninstalled, even if reinstalled, a factory reset may be required to re-obtain full functionality."

That's 🔥 right?

@schbrns
Copy link

schbrns commented Oct 28, 2024

This is a public PR. 💀 Thought it was internal. My above comment is NOT how to speak to a contributor.

@AnonymousWP
Copy link
Member Author

I hear what you're saying when you say I should open a PR to discuss it but I'll save us both the time and provide it right here, along with justification.

Jutification: Simply the REMOVAL AND REINSTALLATION of Messages, breaks CORE FUNCTIONALITY on MOST CARRIERS/OEMS GLOBALLY, to the point of needing A FACTORY RESET, and the only workaround is to KEEP IT INSTALLED (REMOVAL: UNSAFE???), alongside a different SMS app that you use.

"description": "Google Messages (https://play.google.com/store/apps/details?id=com.google.android.apps.messaging)\nSMS and RCS app.\nNOTE: Possibly a global dependency for SMS, MMS, RCS, OTP, and other services/verifications.\nWARNING: Once disabled/uninstalled, even if reinstalled, a factory reset may be required to re-obtain full functionality."

That's 🔥 right?

Ah okay, didn't know this applies to many other OEMs as well (to the point you need a factory reset). Haven't seen it before, nor other people reporting it. 😄 Wonder why nobody reported breaking core functionality and needing a factory reset then.

@schbrns
Copy link

schbrns commented Oct 28, 2024

I hear what you're saying when you say I should open a PR to discuss it but I'll save us both the time and provide it right here, along with justification.
Jutification: Simply the REMOVAL AND REINSTALLATION of Messages, breaks CORE FUNCTIONALITY on MOST CARRIERS/OEMS GLOBALLY, to the point of needing A FACTORY RESET, and the only workaround is to KEEP IT INSTALLED (REMOVAL: UNSAFE???), alongside a different SMS app that you use.
"description": "Google Messages (https://play.google.com/store/apps/details?id=com.google.android.apps.messaging)\nSMS and RCS app.\nNOTE: Possibly a global dependency for SMS, MMS, RCS, OTP, and other services/verifications.\nWARNING: Once disabled/uninstalled, even if reinstalled, a factory reset may be required to re-obtain full functionality."
That's 🔥 right?

Ah okay, didn't know this applies to many other OEMs as well (to the point you need a factory reset). Haven't seen it before, nor other people reporting it. 😄 Wonder why nobody reported breaking core functionality and needing a factory reset then.

To the point of needing factory reset, probably not consistently, but definitely between certain OS subversions.
But also, I say that under the assumption that this type of thing is rarely ever isolated to one device/carrier/OEM.
It's almost always spread in a patterned way.
I think it may be a little dramatic of a description but it blankets what Google is doing with their Messages app better, which is too much.
It's a form of phone number verification now, not an SMS/RCS app. 😦

@AnonymousWP AnonymousWP requested a review from a team November 2, 2024 15:18
@AnonymousWP AnonymousWP merged commit 62df44f into main Nov 2, 2024
20 of 21 checks passed
@AnonymousWP AnonymousWP deleted the 668-pkgscope-comgoogleandroidappsmessaging-breaks-sms-on-unihertz-titan-pocket branch November 2, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package::documentation Improve a description/recommendation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg(scope): com.google.android.apps.messaging breaks sms on Unihertz Titan Pocket
2 participants