Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): fix, patch, and optimize(perf) Auto theme #702

Merged
merged 3 commits into from
Nov 3, 2024
Merged

fix(theme): fix, patch, and optimize(perf) Auto theme #702

merged 3 commits into from
Nov 3, 2024

Conversation

Rudxain
Copy link
Member

@Rudxain Rudxain commented Oct 28, 2024 •
edited
Loading

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Oct 28, 2024 •
edited
Loading

Here's the code health analysis summary for commits 47980f6..cb83e84. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ Success
❗ 2 occurences introduced
🎯 2 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain Rudxain self-assigned this Oct 28, 2024
@Rudxain Rudxain added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file refactor Rework of code — behaviour doesn't change UI Related to the UI labels Oct 28, 2024
@Rudxain

This comment was marked as resolved.

Sign in to view
@Rudxain Rudxain marked this pull request as ready for review October 28, 2024 02:27
@Rudxain Rudxain requested a review from a team October 28, 2024 02:41
@Rudxain
Copy link
Member Author

Rudxain commented Oct 28, 2024

I should've broken up the mono-commit into multiple conventional-commits 😅

@Rudxain
Copy link
Member Author

Rudxain commented Oct 29, 2024

It works now! IDK why lazy needs to be added to the static (bug in static_init?)

@adhirajsinghchauhan adhirajsinghchauhan merged commit 91341a5 into main Nov 3, 2024
20 of 21 checks passed
@adhirajsinghchauhan adhirajsinghchauhan deleted the hotfix/auto-theme branch November 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhirajsinghchauhan adhirajsinghchauhan adhirajsinghchauhan approved these changes

Assignees

@Rudxain Rudxain

Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request refactor Rework of code — behaviour doesn't change UI Related to the UI
Projects
None yet
Milestone
No milestone
2 participants
@Rudxain @adhirajsinghchauhan