Skip to content

Fix callouts with FileIcons #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

teddysupercuts
Copy link
Contributor

@teddysupercuts teddysupercuts commented May 5, 2025

Fix: #503

I have tested this chang on my own fork of unstructured-ingest that I use for processing our customer data. It includes this fix and many other bug fixes that I would like to merge in!

Copy link
Contributor

@mateuszkuprowski mateuszkuprowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid and non-breaking improvement. I think we should integrate it.

@teddysupercuts
Copy link
Contributor Author

teddysupercuts commented May 7, 2025

@mateuszkuprowski I don't think I am allowed to run the CI checks that include an API key. All the CI checks that fail are failing cause of missing API keys. I think I don't have access to your secrets.

Can you either:

  1. add me to your Github org so I can run CI checks that require secrets
  2. merge my commit into a branch of your own so that CI checks can run and I still get credited as a commit author

@teddysupercuts
Copy link
Contributor Author

teddysupercuts commented May 7, 2025

Perhaps @mpolomdeepsense can also help

@mpolomdeepsense mpolomdeepsense changed the base branch from main to fix/notion-file-icons May 9, 2025 09:04
@mpolomdeepsense mpolomdeepsense merged commit 9abc2ce into Unstructured-IO:fix/notion-file-icons May 9, 2025
25 of 36 checks passed
mpolomdeepsense added a commit that referenced this pull request May 12, 2025
## NOTE: In order to fully test this user's contribution I had to merge
the changes to a non-main branch first. This PR is only for testing the
full CI flow + bumping version and changelog.

Fix: #503

User:
**I have tested this chang on my own fork of `unstructured-ingest` that
I use for processing our customer data. It includes this fix and many
other bug fixes that I would like to merge in!**

---------

Co-authored-by: Teddy Wahle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notion page fails to sync where there's a Callout with a "file" Icon
3 participants