Fix sort_page_element. ensures that sorting is stable and not random. #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprados
force-pushed
the
pprados/fix-sort-page-elements
branch
from
73f713a to
0e4da68
Compare
|
Hi @pprados could you please write up a unit test that:
|
pprados
force-pushed
the
pprados/fix-sort-page-elements
branch
from
4534f07 to
ca263ec
Compare
…into pprados/fix-sort-page-elements # Conflicts: # test_unstructured/partition/pdf_image/test_pdf.py
badGarnet
reviewed
Apr 7, 2025
|
done. |
badGarnet
approved these changes
Apr 7, 2025
approved. Thanks for the contribution! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sort_page_element() use the element id to sort the elements.
Two executions of the same code, on the same file, produce different results. The order of the elements is random.
This makes it impossible to write stable unit tests, for example, or to obtain reproducible results.