correctly build offload for default OMP_FLAGS_OFFLOAD_* settings#181
Open
milthorpe wants to merge 7 commits into
Open
correctly build offload for default OMP_FLAGS_OFFLOAD_* settings#181milthorpe wants to merge 7 commits into
milthorpe wants to merge 7 commits into
Conversation
…efetch optimization (UoB-HPC#177)
…matic prefetch optimization (UoB-HPC#177)" This reverts commit 06c3d53.
Revert "Remove AdaptiveCpp workaround in dpl_shim.h to allow for automatic prefetch optimization"
Revert "Rename Julia package to `BabelStream.jl` and add compats"
It seems like Ubuntu adds -fcf-protection=full as a default flag for GCC, which is not supported with AMD OpenMP offload -foffload=amdgcn-amdhsa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OpenMP target offload, there are a few default
OMP_FLAGS_OFFLOAD_<COMPILER?>_<VENDOR?settings, which may work for some systems e.g. OLCF Frontier. However, setting this flag tuple doesn't currently setOMP_TARGET_GPU, so the application doesn't actually compile for offload.This fix defines
OMP_TARGET_GPUwheneverOMP_FLAGS_OFFLOAD_<COMPILER?>_<VENDOR?is defined. With this fix, BabelStream correctly builds for OLCF Frontier with: