fix: on xpress management page only load calls filter when there are instrument(s) in the technique(s)#1397
Merged
mutambaraf merged 2 commits intodevelopfrom Mar 5, 2026
Merged
Conversation
mutambaraf
requested review from
a team,
bolmsten and
ellen-wright
and removed request for
a team
mutambaraf
changed the title
ellen-wright
approved these changes
Mar 4, 2026
mutambaraf
requested review from
yoganandaness
and removed request for
bolmsten and
simonfernandes
yoganandaness
approved these changes
Mar 5, 2026
Contributor
yoganandaness
left a comment
yoganandaness
left a comment
There was a problem hiding this comment.
I am approving this.
But it think, it is best to add the condition on the backend rather than frontend. Frontend can be easily hijacked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where call filters were being loaded on the Xpress management page even when no instruments were associated with the techniques.
Motivation and Context
We only want to show calls when the is an associated instruments
Changes
apps/frontend/src/components/techniqueProposal/TechniqueProposalTable.tsx.How Has This Been Tested?
Fixes Jira Issue
Closes: UserOfficeProject/issue-tracker#1536
Depends On
Tests included/Docs Updated?