Fix Tooltip padding #1263
Merged
Fix Tooltip padding #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👀 Styleguide deployedSee the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1263/ |
fedorov-xyz
reviewed
Dec 22, 2020
src/components/Tooltip/Tooltip.css
Outdated
| @@ -34,7 +34,7 @@ | |||
| .Tooltip__content { | |||
| background-color: #47a3ff; | |||
| box-shadow: 0 4px 32px 0 rgba(0, 0, 0, .16), 0 0 4px 0 rgba(0, 0, 0, .04); | |||
| padding: 6px 16px; | |||
| padding: 8.5px 12px 9.5px; | |||
There was a problem hiding this comment.
А с дробными пикселями всё ок будет?
There was a problem hiding this comment.
хм, и правда, дробные округляются игнорируются
size-limit report 📦
|
|
Design Review: OK |
ewgenius
force-pushed
the
fix/tooltip-paddings
branch
from
99debe2 to
909c9cb
Compare
fedorov-xyz
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1261
Before
After