fix(ordering): delete unordered products when order round closes#432
Open
tobiascadee wants to merge 1 commit intomainfrom
Open
fix(ordering): delete unordered products when order round closes#432tobiascadee wants to merge 1 commit intomainfrom
tobiascadee wants to merge 1 commit intomainfrom
Conversation
When MailOrderLists processes a closed order round, delete all products from that round that have no paid order items. This cleans up ~50% of products that are entered but never ordered. Closes #430 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MailOrderListsprocesses a closed order round, all products from that round with no paid order items are now deletedTest plan
test_unordered_products_are_deleted_when_order_is_placed— verifies unordered product is deleted while ordered product survivestest_products_with_only_unpaid_orders_are_deleted_when_order_is_placed— verifies products with only unpaid orders are also cleaned upCloses #430
🤖 Generated with Claude Code