Fix zizmor warning in release workflow #2779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| replace: "Next\n----\n\n${{ steps.calver.outputs.release }}\n${{ steps.changelog_underline.outputs.underline\ | ||
| \ }}" | ||
| replace: |- | ||
| Next\n----\n\n${{ steps.calver.outputs.release }}\n${{ steps.changelog_underline.outputs.underline }}\n |
There was a problem hiding this comment.
Block scalar makes \n literal instead of newlines
The YAML block scalar syntax (|-) treats \n as literal backslash-n characters instead of actual newlines. The original double-quoted string correctly interpreted \n as newline characters. This will cause the changelog to have literal \n text inserted instead of proper line breaks, breaking the changelog formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use YAML block scalar syntax for replace field to fix zizmor warning.
Note
Refines the release workflow to correctly handle a multi-line replacement when updating
CHANGELOG.rst..github/workflows/release.yml, changes thegha-find-replacereplacefield to a YAML block scalar, preserving newlines (Next\n----\n\n...\n) in the inserted changelog headerWritten by Cursor Bugbot for commit d06536e. This will update automatically on new commits. Configure here.