Fix: scattergun that has knockback cannot be fired on preround

[M60TM]

Description

• During the pre-round (before setup time finishes), the CTFScattergun with the set_scattergun_has_knockback attribute set to 1 cannot be fired because the code bypasses BaseClass::FireBullet. This PR fixes that behavior.

[JoriKos]

I could be 100% wrong but isn't if ( !pOwner ) a check that's seeing if pOwner successfully contains a player, and if it doesn't then it shouldn't proceed with anything below it because the game crashes?

[bakugo]

That check makes no sense regardless because the pPlayer passed into the function is already the owner of the weapon. So pOwner can be removed entirely and replaced with pPlayer.

[JoriKos]

Wouldn't it still, in its current state, cause a crash if it doesn't contain a player?

[bakugo]

It will always contain a player, as this was already checked higher up in the call stack:

source-sdk-2013/src/game/shared/tf/tf_weaponbase_gun.cpp

Lines 94 to 97 in c623a7c

	// Get the player owning the weapon.
	CTFPlayer *pPlayer = ToTFPlayer( GetPlayerOwner() );
	if ( !pPlayer )
	return;

[M60TM]

Would it be better to replace pOwner with pPlayer? pOwner and pPlayer are used interchangeably in the code.

[mastercoms]

Maybe best to just change HasKnockback. Or else some other effects will possibly run in ApplyPostHitEffects and other places.

[M60TM]

The codes in FireBullet is intended to prevent movement via knockback before the round starts. Modifying the HasKnockback function could potentially introduce side effects in other parts of the code.

[bakugo]

Yes, modifying HasKnockback() directly would affect the hardcoded animation overrides in CTFScatterGun::SendWeaponAnim().

Also, it's probably important to note that these changes do not affect the entirety of setup time, only the short freeze time at the start where players cannot move. This check was likely added purely to prevent scouts from boosting themselves forward during that time, and disabling on-hit effects isn't necessary.