[TF2] Put other games' impulse commands behind preprocessor directive#1841
Open
YourSourceBoiii wants to merge 1 commit intoValveSoftware:masterfrom
Open
[TF2] Put other games' impulse commands behind preprocessor directive#1841YourSourceBoiii wants to merge 1 commit intoValveSoftware:masterfrom
YourSourceBoiii wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
Contributor
|
Would this prevent spawning an airboat in Portal? It's a critical part of that game :^) |
Author
It wouldn't because Portal players use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE: Honestly, what's the point of having all these game specific
impulseconsole commands in the engine-wide code?impulse 82spawns the HL2 jeep for example, but HL2 is the only game that has those.They should be put behind corresponding
#ifdefstatements if you ask me