[core] fix: cmake module path #508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes 3 issues with this line. - CMAKE_HOME_DIRECTORY is an internal var that is no supposed to be used - CMAKE_HOME_DIRECTORY/CMAKE_SOURCE_DIR can be wrong, as it does not always refer to the current CMakeLists.txt (eg in fetch content) - append to list instead of setting/overwriting it
Author
|
Do note that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 3 issues with this line.
CMAKE_HOME_DIRECTORYis an internal var that is no supposed to be usedCMAKE_HOME_DIRECTORY/CMAKE_SOURCE_DIRcan be wrong, as it does not always refer to the currentCMakeLists.txt(eg in fetch content)