Keep merge inside --optimize - #377
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge now belongs to
--optimizerather than running on every build, so thethree levels each mean something distinct:
--optimize merge--optimizePreviously the default collapsed the tree too, which left
--optimize mergewith almost nothing extra to do and made the search-cost metrics credit
--optimizewith a gain the default already delivered.The tradeoff is that the default now summarises every extracted node: about 16%
more summary calls across the example corpus, and up to 48% on a document whose
outline has many one-page subsections. Callers who want the cheaper, flatter
tree ask for it with
--optimize merge, which costs nothing beyond the mergeitself.
key_itemsonly appears once a merge has run, so it is now documented as an--optimizefield. The non-Flash pipeline inpage_index.pyis unchanged: ithas no optimize switch and has always collapsed, so it keeps doing so.