feat: add markets tab to Dashboard page#5321
Draft
therealemjy wants to merge 1 commit intofeat/dashboard-vaultsfrom
Draft
feat: add markets tab to Dashboard page#5321therealemjy wants to merge 1 commit intofeat/dashboard-vaultsfrom
therealemjy wants to merge 1 commit intofeat/dashboard-vaultsfrom
Conversation
🦋 Changeset detectedLatest commit: 5eae5a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
fd81d9e to
9913221
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
9913221 to
673e821
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
673e821 to
eead8d1
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
eead8d1 to
8dea7f1
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
8dea7f1 to
9584e93
Compare
Contributor
therealemjy
force-pushed
the
feat/dashboard-markets
branch
2 times, most recently
from
002f47e to
da7ba97
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
da7ba97 to
d77bbe9
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
d77bbe9 to
75b9ddb
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
75b9ddb to
2756cdf
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
2756cdf to
4e4d523
Compare
therealemjy
force-pushed
the
feat/dashboard-markets
branch
from
4e4d523 to
5eae5a0
Compare
| }, | ||
| ); | ||
|
|
||
| const txTypeSelectOptions = useMemo(() => { |
Contributor
There was a problem hiding this comment.
No need for useMemo?
| "pools": { | ||
| "borrowTab": { | ||
| "placeholder": { | ||
| "title": "暂无借入仓位" |
Contributor
There was a problem hiding this comment.
The translations of "borrow" and "supply" are not consistent. Might need to consult Zed to standardize the terms and apply to all related places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket(s)
VPD-415
Changes
evm app