Closed
Conversation
fred-venus
reviewed
Jan 7, 2026
fred-venus
reviewed
Jan 7, 2026
fred-venus
reviewed
Jan 7, 2026
Contributor
|
setting itself look good, but i feel like all the perssmissons goes to the keeper instead of timelock is werid |
Contributor
Author
In actual mainnet and testnet setup the permissions will go to timelock. For making it easy to test different scenarios I have given permissions to keeper. Once the contracts are audited and we do the final deployment we will revoke all the permissions granted in this PR. |
fred-venus
previously approved these changes
Jan 9, 2026
Debugger022
changed the title
Debugger022
force-pushed
the
feat/vpd-402
branch
from
0ba62be to
e2aab58
Compare
- Introduced new ABI files for DexOracle and SentinelOracle. - Created bscmainnet.ts for VIP-900 simulation, including tests for ownership and permissions. - Implemented proposal logic for accepting ownership and granting permissions to the keeper and governance timelocks. - Updated governance permissions for DeviationSentinel on comptrollers.
…tion - Wraps governance commands with resetMarketState before and handleDeviation after to prevent state conflicts with DeviationSentinel - Handles CF updates, pause/unpause, and e-mode changes safely - Automatically unpauses borrow/mint before governance changes in case Sentinel had paused them
- Move DeviationSentinel setup VIP and simulation from vip-580 to vip-900 - Move _setActionsPaused addendum VIP and simulation from vip-580 to vip-900 - Move unpause/restore CF addendum-2 VIP and simulation from vip-778 to vip-900 - Copy required ABIs (ERC20, ResilientOracle, comptroller) to vip-900 - Rename exported functions from vip580*/vip778* to vip900* - Update all import paths and VIP titles to reference vip-900
…ip-900 - Delete vips/vip-580/bsctestnet.ts and bsctestnet-addendum.ts - Delete vips/vip-778/bsctestnet-addendum-2.ts - Delete vips/vip-582/bsctestnet-addendum-2.ts (duplicate of vip-778) - Delete corresponding simulation files from vip-580, vip-582, vip-778 - Non-DeviationSentinel files (VToken/Fermi upgrades) in vip-778 and vip-582 are retained
- Refactored tests to use isAllowedToCall instead of hasPermission for permission checks - Updated simulation to impersonate contract addresses for accurate permission context - Synced AccessControlManager ABI with latest contract, replacing PermissionGranted/Revoked with RoleGranted/Revoked and adding new role-based methods - Populated deployed contract addresses for DeviationSentinel, SentinelOracle, UniswapOracle and PancakeSwapOracle in VIP-900 config - Adjusted event expectations and comments to reflect BSC mainnet ACM event behavior
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN