fix: fix some bugs around dialog emulation #1131
Open
+35
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenc-nanashi
changed the title
sevenc-nanashi
commented
Nov 9, 2025
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
FlorianMichael
requested changes
Nov 12, 2025
Member
FlorianMichael
left a comment
FlorianMichael
left a comment
There was a problem hiding this comment.
thanks for your changes, overall looks good. just some minor things I would like to address before merging
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Show resolved
Hide resolved
common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/data/Button.java
Show resolved
Hide resolved
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
Author
|
Applied your reviews, thank you for the review. |
FlorianMichael
approved these changes
Nov 14, 2025
Member
FlorianMichael
left a comment
FlorianMichael
left a comment
There was a problem hiding this comment.
Just a few minor nitpicks before merge
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Outdated
Show resolved
Hide resolved
...a/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/provider/ChestDialogViewProvider.java
Show resolved
Hide resolved
common/src/main/java/com/viaversion/viabackwards/protocol/v1_21_6to1_21_5/data/Dialog.java
Show resolved
Hide resolved
Co-authored-by: FlorianMichael <[email protected]>
Author
|
Applied your reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some bugs while I'm trying to play with True Crafter Mode Datapack.
I tried to fix these bugs, but I'm very new to Java and Minecraft server plugins; sorry if I made some mistakes.
This PR fixes: