Make required fields required; to-one relations don’t need arguments#15
Open
mattleff wants to merge 2 commits intoVincit:masterfrom
Open
Make required fields required; to-one relations don’t need arguments#15mattleff wants to merge 2 commits intoVincit:masterfrom
mattleff wants to merge 2 commits intoVincit:masterfrom
Conversation
Collaborator
|
Does this make any sense? If a property is needed when creating or updating a model it doesn't necessarily mean that it needs to be selected when querying? That's what json schema is in objection: an input validation schema and nothing else. Or is that what required means in graphql (I have never used it)? |
Contributor
Author
|
@koskimas As the spec explains:
So, I'm not quite using the correct term. This should be called |
…uired # Conflicts: # lib/SchemaBuilder.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the types generated more accurate: