Skip to content

VCST-5014: Fix 20 entries limitation#11

Merged
OlegoO merged 1 commit into
devfrom
fix/VCST-5014
Apr 29, 2026
Merged

VCST-5014: Fix 20 entries limitation#11
OlegoO merged 1 commit into
devfrom
fix/VCST-5014

Conversation

@OlegoO
Copy link
Copy Markdown
Contributor

@OlegoO OlegoO commented Apr 28, 2026

Description

fix: 20 entries limitation

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-5014

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.SqlQueries_3.1001.0-pr-11-3db1.zip


Note

Medium Risk
Changes list loading to use paged search/reports requests and introduces UI pagination, which could affect list completeness or navigation if paging parameters/total counts don’t match backend behavior.

Overview
Removes the effective 20-item cap in the SQL queries list by adding pagination UI and switching list loading to paged API calls.

sql-query-list now computes skip/take from pageSettings, updates pageSettings.totalItems from totalCount, and initializes pagination via bladeUtils.initializePagination($scope) (including the 403 fallback to reports).

Reviewed by Cursor Bugbot for commit 3db146a. Bugbot is set up for automated code reviews on this repo. Configure here.

fix: 20 entries limitation
@OlegoO OlegoO requested a review from EugeneOkhriemnko April 28, 2026 10:39
@sonarqubecloud
Copy link
Copy Markdown

@vc-ci
Copy link
Copy Markdown
Contributor

vc-ci commented Apr 28, 2026

🧪 Katalon Test Report — ✅ PASSED

🔢 Total ✅ Passed ❌ Failed
13 13 0
📋 Suite details
Suite Test Suites/Modules/module_Assets
Failures 0
Errors 0
Timestamp 28-04-2026T10:49:26

🔗 View run · Commit: 0c920d2

@OlegoO OlegoO merged commit f408045 into dev Apr 29, 2026
7 of 8 checks passed
@OlegoO OlegoO deleted the fix/VCST-5014 branch April 29, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants