VCST-5014: Fix 20 entries limitation#11
Merged
Merged
Conversation
fix: 20 entries limitation
|
Contributor
🧪 Katalon Test Report — ✅ PASSED
📋 Suite details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
fix: 20 entries limitation
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5014
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.SqlQueries_3.1001.0-pr-11-3db1.zip
Note
Medium Risk
Changes list loading to use paged
search/reportsrequests and introduces UI pagination, which could affect list completeness or navigation if paging parameters/total counts don’t match backend behavior.Overview
Removes the effective 20-item cap in the SQL queries list by adding pagination UI and switching list loading to paged API calls.
sql-query-listnow computesskip/takefrompageSettings, updatespageSettings.totalItemsfromtotalCount, and initializes pagination viabladeUtils.initializePagination($scope)(including the 403 fallback toreports).Reviewed by Cursor Bugbot for commit 3db146a. Bugbot is set up for automated code reviews on this repo. Configure here.