Skip to content

fix(restapi): VCST-4942 catalog review follow-ups (A/B/C)#137

Merged
Lenajava1 merged 1 commit into
devfrom
vcst-4942-catalog-followups
Apr 17, 2026
Merged

fix(restapi): VCST-4942 catalog review follow-ups (A/B/C)#137
Lenajava1 merged 1 commit into
devfrom
vcst-4942-catalog-followups

Conversation

@Lenajava1
Copy link
Copy Markdown
Collaborator

A — cleanup:

  • wrap cloned-product verify in try/finally (test_product.py) so clone is removed even if assertions fail
  • add asset + folder teardown to test_asset_add_to_product (prevents leaks across runs)
  • reverse teardown order in catalog/conftest.py factories for consistency with sibling modules

B — client API:

  • add RestClient.post_multipart() for file uploads; strip JSON Content-Type when files are passed
  • migrate catalog/test_assets.py and platform/test_assets.py off rest_client._session

C — coverage:

  • add test_asset_delete (catalog)
  • add test_category_nested (parent/child parentId wiring)
  • add test_category_get_not_found + test_product_get_not_found negative paths

A — cleanup:
- wrap cloned-product verify in try/finally (test_product.py) so clone is removed even if assertions fail
- add asset + folder teardown to test_asset_add_to_product (prevents leaks across runs)
- reverse teardown order in catalog/conftest.py factories for consistency with sibling modules

B — client API:
- add RestClient.post_multipart() for file uploads; strip JSON Content-Type when files are passed
- migrate catalog/test_assets.py and platform/test_assets.py off rest_client._session

C — coverage:
- add test_asset_delete (catalog)
- add test_category_nested (parent/child parentId wiring)
- add test_category_get_not_found + test_product_get_not_found negative paths

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

REST API Test Results

266 tests  +4   264 ✅ +4   20s ⏱️ -1s
  3 suites ±0     2 💤 ±0 
  3 files   ±0     0 ❌ ±0 

Results for commit 4cc975d. ± Comparison against base commit f867b71.

@Lenajava1 Lenajava1 merged commit 5c9622c into dev Apr 17, 2026
3 checks passed
@Lenajava1 Lenajava1 deleted the vcst-4942-catalog-followups branch April 29, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant