fix: remove Component.wait_for_results networkidle pattern (C8)#152
Merged
Conversation
Playwright documents `networkidle` as DISCOURAGED — it hangs on apps
with WebSocket/polling traffic. Project memory and the create-ui-layer
SKILL already said "use wait_until=load, not networkidle", but the
Component base class advertised the discouraged helper anyway.
- Delete `Component.wait_for_results()` from page_objects/components/component.py
- Replace 13 active call sites across 3 e2e test files with explicit
Playwright assertions:
- 9 positive cases (followed by `find_pickup_location_cards(...)`
which snapshots via `.all()`) → `expect(...pickup_location_cards.first).to_be_visible()`
- 4 cases where the next line was already an auto-waiting `expect(...)` → just delete
- Update .claude/skills/create-ui-layer/SKILL.md to remove the
wait_for_results sample and explicitly say "no networkidle, wait via
expect() on specific locators". Prevents the next UI-layer
generation from reintroducing the pattern.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
REST API Test Results295 tests 292 ✅ 27s ⏱️ Results for commit a770b1a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright documents
networkidleas DISCOURAGED — it hangs on apps with WebSocket/polling traffic. Project memory and the create-ui-layer SKILL already said "use wait_until=load, not networkidle", but the Component base class advertised the discouraged helper anyway.Component.wait_for_results()from page_objects/components/component.pyfind_pickup_location_cards(...)which snapshots via.all()) →expect(...pickup_location_cards.first).to_be_visible()expect(...)→ just delete