Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: large refactoring of how compilation errors are handled #180

Merged
merged 14 commits into from
Aug 27, 2024
Merged

refactor: large refactoring of how compilation errors are handled #180

merged 14 commits into from
Aug 27, 2024

Conversation

plusvic
Copy link
Member

@plusvic plusvic commented Aug 27, 2024

The changes in this PR include:

  • Redesign how the compilation errors are exposed in the Rust API. With this change users of the API have access to more error details, including the structure of error reports. These changes are backward-incompatible, though.
  • The CLI now shows multiple compilation errors at a time, instead of showing only the first error found.
  • All the error details exposed in the Rust API are also exposed in the C API and the Golang API.

plusvic added 14 commits August 23, 2024 11:58
@plusvic
refactor: first phase of a large refactoring of errors and warnings
9de5278
@plusvic
refactor: include a reference to the code cache on each Report.
851de43
@plusvic
Merge branch 'main' into refactor_errors
b815c6d
@plusvic
chore: don't expose CodeLoc.
e9b8213
@plusvic
fix: compilation error when fast-regexp feature is disabled.
6d074ed
@plusvic
docs: document errors
51bf93c
@plusvic
feat: implement API that exposes error/warning details
329adc4
@plusvic
refactor(capi): improvements to error handling in C API
2365cfc
@plusvic
fix: compilation errors when serde feature is disabled for the `yar…
ecd6443 
…a-x-parser` crate.
@plusvic
fix: use preserve_order feature in serde_json to prevent unstable…
adf4e30 
… field order in JSON
@plusvic
feat: allow collecting all errors produced during the compilation
64c2747 
This adds the `Compiler::errors` methods which returns all the errors produced during the compilation. With this change, the CLI can print all the errors found, instead of printing only the first one.
@plusvic
feat(capi): implement the yrx_compiler_errors_json function that re…
53ff1ef 
…turns the compilation errors in JSON format.
@plusvic
feat: add the full text report to the JSON representation of errors.
c7e32fe
@plusvic
feat(go): implement Compiler.Errors that returns the compilation er…
ed818ac 
…rors.
@plusvic plusvic merged commit 7def597 into main Aug 27, 2024
32 checks passed
@plusvic plusvic deleted the refactor_errors branch August 27, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@plusvic