VIDSOL-217: Use global variables to change fontFamily and colors #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobal-variables-fontFamily-colors
…c.ts-snapshots/Landing-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
behei-vonage
previously approved these changes
Oct 13, 2025
…c.ts-snapshots/Landing-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Landing-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Unsupported-browser-page-UI-test-1-firefox-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Electron-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Google-Chrome-Fake-Devices-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Microsoft-Edge-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Mobile-Chrome-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-Opera-linux.png
…c.ts-snapshots/Waiting-page-UI-test-1-firefox-linux.png
|
behei-vonage
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Use global variables to change fontFamily and colors to make changes faster.
How should this be manually tested?
Change values and see if all components are updated accordingly in customTheme.ts file
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-217
Checklist
[X] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?