VIDSOL-280: Unit test fixes and configuration refinements #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnny-quesada-developer
changed the title
johnny-quesada-developer
changed the title
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
d74028e to
a0d05c8
Compare
OscarFava
changed the title
Base automatically changed from
johnny/VIDSOL-279-WEB-aliases-and-configuration-updates
to
develop
October 30, 2025 10:22
johnny-quesada-developer
changed the title
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
a0d05c8 to
18a230d
Compare
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
18a230d to
a0d05c8
Compare
Contributor
|
fyi, some merge conflicts |
johnny-quesada-developer
dismissed
OscarFava’s stale review
The merge-base changed after approval.
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
a0d05c8 to
6d8ac7f
Compare
Contributor
Author
Thanks! I already rebase with develop |
...c/Context/BackgroundPublisherProvider/useBackgroundPublisher/useBackgroundPublisher.spec.tsx
Show resolved
Hide resolved
frontend/src/components/MeetingRoom/ParticipantList/ParticipantList.spec.tsx
Show resolved
Hide resolved
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
6d8ac7f to
d3f10b6
Compare
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
d3f10b6 to
f973b34
Compare
Unit tests were not isolated, tests were unstable, and reliability was compromised.
johnny-quesada-developer
force-pushed
the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
from
f973b34 to
b7db2f7
Compare
|
johnny-quesada-developer
deleted the
johnny/vidsol-280-unit-test-fixes-and-refinements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
This pull request introduces the proper cleanups after each test to ensure that all mocks and global states are reset.
By enforcing isolation at the test environment level, we can immediately detect tests that rely on shared state or unclean mocks.
This change:
Once merged, this will make our Vitest suite more stable, maintainable, and aligned with industry best practices for React unit testing.
How should this be manually tested?
Check nothing is broken and tests are passing
What are the relevant tickets?
Resolves VIDSOL-280
Checklist
[x] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?