Skip to content

feat(NodeGrading): Add option to expand Match and idea summaries#2283

Open
breity wants to merge 2 commits intodevelopfrom
expand-component-summaries
Open

feat(NodeGrading): Add option to expand Match and idea summaries#2283
breity wants to merge 2 commits intodevelopfrom
expand-component-summaries

Conversation

@breity
Copy link
Member

@breity breity commented Mar 9, 2026

Changes

  • Adds a button to expand Match and Ideas Detected summaries in the NodeGradingComponent of the Classroom Monitor.
  • Expanded view opens in a fullscreen dialog.
  • Some style and layout updates.
Screenshot 2026-03-09 at 2 02 56 PM Screenshot 2026-03-09 at 2 03 53 PM

Test

  • Make sure you can expand and collapse (close) the Match and Ideas Detected summaries.
  • Make sure the summaries display and work properly.

@breity breity requested a review from hirokiterashima March 9, 2026 21:04
@breity breity self-assigned this Mar 9, 2026
@qltysh
Copy link

qltysh bot commented Mar 9, 2026

❌ 1 blocking issue (1 total)

Tool Category Rule Count
qlty Structure Function with many parameters (count = 6): constructor 1

private cRaterService: CRaterService,
private dataService: TeacherDataService,
private dialog: MatDialog,
private summaryService: SummaryService
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 6): constructor [qlty:function-parameters]

@qltysh
Copy link

qltysh bot commented Mar 9, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: F
...torComponents/component-summary/component-summary.component.ts70.0%62, 149-150
Total70.0%
🤖 Increase coverage with AI coding...

In the `expand-component-summaries` branch, add test coverage for this new code:

- `src/assets/wise5/classroomMonitor/classroomMonitorComponents/component-summary/component-summary.component.ts` -- Lines 62 and 149-150

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expanded view looks great! The buttons to expand/collapse makes sense.

Is it just me, or does the expand icon looks a bit off-centered?
Image

Also, I added some minor inline code improvement suggestions.

Comment on lines +15 to +16
}
@if (data.type === 'match') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use else-if for clarity

Suggested change
}
@if (data.type === 'match') {
} @else if (data.type === 'match') {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants