Skip to content

fix(LabelService): Replace jQuery selector#2295

Merged
breity merged 2 commits intodevelopfrom
label-service-jquery-bug
Mar 31, 2026
Merged

fix(LabelService): Replace jQuery selector#2295
breity merged 2 commits intodevelopfrom
label-service-jquery-bug

Conversation

@breity
Copy link
Copy Markdown
Member

@breity breity commented Mar 30, 2026

Changes

Replace a jQuery selector with native js document selector. This was breaking the student work view for Label activities.

Test

  • Label activities work as before.
  • You can view student work for Label activities in the Teacher Tools.

@breity breity self-assigned this Mar 30, 2026
@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 31, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: D
src/assets/wise5/components/label/labelService.ts50.0%303
Total50.0%
🤖 Increase coverage with AI coding...

In the `label-service-jquery-bug` branch, add test coverage for this new code:

- `src/assets/wise5/components/label/labelService.ts` -- Line 303

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@breity breity merged commit a6ccd16 into develop Mar 31, 2026
6 of 7 checks passed
@breity breity deleted the label-service-jquery-bug branch March 31, 2026 07:02
@hirokiterashima
Copy link
Copy Markdown
Member

🎉 This PR is included in version 5.221.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants