feat(Authoring): Add global show activity title and icon settings - #2340
Merged
breity merged 2 commits intoSep 10, 2026
Merged
Conversation
breity
added
the
enhancement
hirokiterashima
approved these changes
Sep 10, 2026
hirokiterashima
left a comment
hirokiterashima
left a comment
Member
There was a problem hiding this comment.
LGTM.
Should we simplify the phrasing "Show activity type icons" => "Show activity icons"? Not sure if "type" is useful for authors here.
I added minor code improvement suggestions inline also.
| } | ||
|
|
||
| protected get showTitle(): boolean { | ||
| return Boolean(this.title && this.themeSettings?.showComponentTitles); |
Member
There was a problem hiding this comment.
Do we need to wrap the boolean evaluation with Boolean()?
Suggested change
| return Boolean(this.title && this.themeSettings?.showComponentTitles); | |
| return this.title && this.themeSettings?.showComponentTitles; |
| } | ||
|
|
||
| protected get showIcon(): boolean { | ||
| return Boolean(this.showTitle && this.themeSettings?.showComponentTypeIcons); |
Member
There was a problem hiding this comment.
Do we need to wrap the boolean evaluation with Boolean()?
Suggested change
| return Boolean(this.showTitle && this.themeSettings?.showComponentTypeIcons); | |
| return this.showTitle && this.themeSettings?.showComponentTypeIcons; |
| metadataChanged: Subject<void> = new Subject<void>(); | ||
| projectIcon: string = ''; | ||
| projectIcons: any = []; | ||
| protected themeSettings: any; |
Member
There was a problem hiding this comment.
Give type?
Suggested change
| protected themeSettings: any; | |
| protected themeSettings: ThemeSettings; |
| metadataChanged: Subject<void> = new Subject<void>(); | ||
| projectIcon: string = ''; | ||
| projectIcons: any = []; | ||
| protected themeSettings: any; |
Member
There was a problem hiding this comment.
Give type?
Suggested change
| protected themeSettings: any; | |
| protected themeSettings: ThemeSettings; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test