feat: block prs with out-of-sync gemfile.lock - #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Lockfile Guardworkflow so a Gemfile/Gemfile.lock desync can never silently break deploys again (the way #510 did — see #519).On every PR it checks the lockfile against the Gemfile using Bundler's own
Definition#nothing_changed?(no gem install, no network resolution needed):REQUEST_CHANGESreview explaining how to fix it.The review is deduplicated via an HTML-comment marker, so repeated pushes don't stack reviews. Fork PRs (read-only token) skip the review steps and just get the failing check.
flowchart LR A[PR opened / updated] --> B{Gemfile.lock in sync?} B -- no --> C[Job fails + blocking review] C --> D[Author runs bundle install, pushes] D --> B B -- yes --> E[Review dismissed, job green]