feat: Add "when" property to Fallback component - #45
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new "when" property to the Fallback component that allows custom control over when fallback content should be displayed. This addresses issue #44 by providing override capability for the default fallback logic which only shows content when no routes match.
Key changes:
- Added
WhenPredicatetype for custom fallback conditions - Modified Fallback component to support conditional rendering via the
whenprop - Created comprehensive test suite covering all routing universes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/types.ts | Added WhenPredicate type definition for custom fallback conditions |
| src/lib/index.ts | Modified exports to be more selective for Router module |
| src/lib/Router/Router.svelte | Added getRouterContextKey function and improved type imports |
| src/lib/Fallback/Fallback.svelte | Implemented when property with conditional rendering logic |
| src/lib/Fallback/Fallback.svelte.test.ts | Added comprehensive test suite covering all routing scenarios |
| src/testing/test-utils.ts | Added testing utilities for router setup and route manipulation |
| docs/testing-guide.md | Added comprehensive testing documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44.