fix: Ensure user-provided onclick event in Link component doesn't override internal onclick - #52
Merged
Conversation
…rride internal onclick
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where user-provided onclick handlers were being overridden by the internal navigation logic in the Link component. The fix ensures that both the internal navigation and any user-provided onclick handlers are executed.
- Extracts user-provided onclick handler from props to prevent it from being overridden
- Calls the user-provided onclick handler after internal navigation logic
- Improves the type annotation for the handleClick event parameter
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.