Skip to content

Conversation

@benlk
Copy link
Collaborator

@benlk benlk commented Jul 19, 2019

🚨 currently broken:

  • galleries on posts

⚠️ unknown:

  • featured media galleries
  • any other places where the gallery styles/js are needed (Gallery widget?)

Changes

  • stops running largo_gallery_enqueue() on every page
  • for all the assets in largo_gallery_enqueue(), enqueue them in the footer

Why

Fixes #1113 by only enqueueing the JS/CSS when it's needed.

To do

  • realize that most of Navis's lightbox code is used on all pages for all images in entry-content
  • see if we can split slideshow from lightbox code
  • better integrate Navis Slideshows plugin into Largo

@benlk benlk added the category: images Issues relating to images label Jul 19, 2019
@benlk benlk changed the base branch from develop to trunk July 19, 2019 23:13
@benlk benlk added the category: performance performance-related issues label Aug 21, 2019
@benlk
Copy link
Collaborator Author

benlk commented Jun 26, 2020

If conditional enqueues aren't working, let's just merge the LESS/CSS with the rest of Largo's styles into one stylesheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: images Issues relating to images category: performance performance-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't enqueue unneeded stylesheets for Navis

2 participants