LLM as text encoder implementation from LLM2CLIP#42
Merged
vdplasthijs merged 8 commits intodevelopfrom Feb 4, 2026
Merged
Conversation
…der dtype unification
vdplasthijs
approved these changes
Feb 4, 2026
Collaborator
vdplasthijs
left a comment
There was a problem hiding this comment.
Great work, curious to see the results! I'll merge this, and we can change the normalisation in a new PR? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I had to do a lot of work arounds to make it work due to dependency issues and unclear environment recommendations from LLM2LCIP. Right now, it uses my forked LLM2vec repo and LLAMA customised version to get rid of flash-atto and spda.
What remains is to unify/decide on model dtypes and potentially adapt LLM2CLIP vision branch as eo encoder.
Before submitting
pytestcommand?