Fix threading violations, crash bugs, resource leaks, and code cleanup#49
Merged
Conversation
Threading:
- currentBackStack: wrap ADB in execute{}, PSI in ReadAction, popup on EDT
- currentApplicationBackStack: same fix, item callback dispatches to background
- currentActivity: resolve PSI in ReadAction on background thread before invokeLater
Crash safety:
- GetFragmentsCommand: safe split access with getOrNull(2) ?: return
- GetApplicationBackStackCommand: safe array bounds with getOrNull, remove !! on find{}
- Debugger: replace client!! with client ?: return@invokeLater to avoid NPE
Resource leaks:
- AdbControllerImp implements Disposable; removeDeviceChangeListener in dispose()
- Disposer.register(project, controller) wires lifetime to project in BaseAction
Code cleanup:
- Remove println() debug statements (SpockAdbViewer, GetApplicationBackStackCommand)
- Fix exception message "Bazinga!!" → professional message in GetApplicationPermission
- Remove duplicate empty setting.addActionListener{} in SpockAdbViewer
- Remove large commented-out WiFi and refresh blocks in SpockAdbViewer
- Remove dead commented-out code in ConnectDeviceOverIPCommand, CheckBoxDialog
- Rename kippAppProcess → killAppProcess (typo fix) in ProcessDeathCommand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.