Handle stack switching in Unsubtyping #7608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the rather complicated subtyping requirements to SubtypingDiscoverer and test that unsubtyping preserves the necessary subtype relationships.
|
uhhh... hold on |
tlively
changed the title
tlively
changed the title
|
This is fixed up and ready to go now |
kripken
approved these changes
May 19, 2025
src/wasm/wasm-ir-builder.cpp
Outdated
| @@ -2471,6 +2471,7 @@ IRBuilder::makeResume(HeapType ct, | |||
| return Err{"the sizes of tags and labels must be equal"}; | |||
| } | |||
| if (!ct.isContinuation()) { | |||
| std::cout << ct.toString() << "\n"; | |||
There was a problem hiding this comment.
Suggested change
| std::cout << ct.toString() << "\n"; |
| ;; CHECK-NEXT: ) | ||
| (func $switch-param | ||
| (local $cont (ref null $cont)) | ||
| (switch $cont $e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the rather complicated subtyping requirements to SubtypingDiscoverer
and test that unsubtyping preserves the necessary subtype relationships.