Open
Conversation
tlively
reviewed
Mar 18, 2026
scripts/test/shared.py
Outdated
| 'imports.wast', # Requires fixing handling of mutation to imported globals | ||
| 'proposals/threads/imports.wast', # Missing memory type validation on instantiation | ||
| 'linking.wast', # Missing global type validation on instantiation | ||
| 'linking.wast', # Incorrectly allows subtyping for table imports |
Member
There was a problem hiding this comment.
Does this mean the test is wrong or that our implementation is wrong?
Member
Author
There was a problem hiding this comment.
Our implementation is wrong, table types should be invariant for imports but I implemented them as covariant (same mistake as Java): link. I'll address this in the next PR.
2591c89 to
ba2c167
Compare
ba2c167 to
6b63ad6
Compare
This reverts commit b075561.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example error message:
Part of #8261.