Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test copy/paste typo #566

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix test copy/paste typo #566

merged 1 commit into from
Oct 25, 2024

Conversation

ejrgilbert
Copy link
Contributor

No description provided.

@tlively
Copy link
Member

tlively commented Oct 25, 2024

Looks right, but curious that the tests weren't previously failing.

@jakobkummerow
Copy link
Contributor

curious that the tests weren't previously failing.

i31.get_s and i31.get_u both trap on (ref.null i31), so this doesn't affect test results.

jakobkummerow
jakobkummerow approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlively
Copy link
Member

tlively commented Oct 25, 2024

Ah, I misread and though that this function was used to test non-null cases.

@tlively tlively merged commit 1f803e1 into WebAssembly:main Oct 25, 2024
1 check passed
@ejrgilbert ejrgilbert deleted the patch-1 branch October 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobkummerow jakobkummerow jakobkummerow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejrgilbert @tlively @jakobkummerow