Skip to content

Run all disabled workloads in tests - #103

Merged
camillobruni merged 7 commits into
WebKit:mainfrom
camillobruni:2025-07-30_run_all_workloads
Jul 30, 2025
Merged

Run all disabled workloads in tests#103
camillobruni merged 7 commits into
WebKit:mainfrom
camillobruni:2025-07-30_run_all_workloads

Conversation

@camillobruni

Copy link
Copy Markdown
Contributor
  • Add "disabled" tag

  • Move default tags processing to the Benchmark class

  • Add more tags test

  • Refactor unittest cli code a bit

  • Change unittest order to get faster failing feedback (single test, disabled test, default suite)

  • Disable broken LuaJSFight for now (we should likely just remove them)

@netlify

netlify Bot commented Jul 30, 2025

Copy link
Copy Markdown

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 53f2acc
🔍 Latest deploy log https://app.netlify.com/projects/webkit-jetstream-preview/deploys/688a16bcb0176e00088f7117
😎 Deploy Preview https://deploy-preview-103--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@camillobruni camillobruni changed the title Run all disabled workloads in unittests Run all disabled workloads in tests Jul 30, 2025

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that is because of this or some earlier change, but the printing/logging of results for the browser actions seems broken, it just shows:

Run Single Suite
  JetStream PREPARE http://localhost:8010/index.html?worstCaseCount=2&iterationCount=3&test=proxy-mobx
  JetStream START
  proxy-mobx [object Object]

see e.g., https://github.com/WebKit/JetStream/actions/runs/16619354890/job/47019721683?pr=103#step:8:18

Also some minor nits.

Comment thread JetStreamDriver.js
Comment thread JetStreamDriver.js
Comment thread tests/run.mjs Outdated
@camillobruni

Copy link
Copy Markdown
Contributor Author

Added logInfo vs. log to preserve console.log behavior for printing object details.

@danleh danleh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@camillobruni
camillobruni merged commit 76a8438 into WebKit:main Jul 30, 2025
10 checks passed
@camillobruni
camillobruni deleted the 2025-07-30_run_all_workloads branch July 30, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants