Fix FFI handling of optional memflow connector_args #254
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nter usage As stated in the documentation, memflow_connector_args are optional, however omitting the memflow_connector_args from the FFI causes an assertion failure in `std::slice::from_raw_parts`. The documentation for `std::slice::from_raw_parts` states that the pointer must be non-null and properly aligned, since it promises to return a slice that actually refers to valid memory. Prior to these changes, the code would attempt to pass a null pointer via args_arr to `std::slice::from_raw_parts` if the optional `memflow_connector_args` were not provided.
|
Thanks for this PR @ajkhoury ! 🚀 I just fixed the Doc / book CI (actions/cache was deprecated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the libmicrovmi documentation,
memflow_connector_argsare optional, however omitting thememflow_connector_argsfrom the FFI causes an assertion failure instd::slice::from_raw_parts. The documentation forstd::slice::from_raw_partsstates that the pointer must be non-null and properly aligned, since it promises to return a slice that actually refers to valid memory. Prior to these changes, the code would attempt to pass a null pointer viaargs_arrtostd::slice::from_raw_partsif the optionalmemflow_connector_argswere not provided.