Skip to content

Fix serverbrowser crash on malformed packet - #102

Open
ppebb wants to merge 2 commits into
WiiLink24:mainfrom
Retro-Rewind-Team:sb-crash-cherry-pick
Open

ppebb wants to merge 2 commits into
WiiLink24:mainfrom
Retro-Rewind-Team:sb-crash-cherry-pick

Conversation

@ppebb

@ppebb ppebb commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Server browser's SendMessageRequest handler does not have appropriate length guards. A packet of

bytes := []byte{
	0x00, 0x08, // Size
	0x02,                      // SendMessage Request
	0x4, 0x5, 0x6, 0x07, 0x08, // Body.
}

Will cause a panic.

This also adds panic recovery to server browser so other missed issues cannot take the server down.

@ppebb
ppebb requested a review from a team August 12, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant