WIP: Fix function call handling according to Microsoft Arm64 variadic function call ABI #37
+422
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackhex
force-pushed
the
fix-va-list
branch
2 times, most recently
from
3b18f93 to
2cb2f8a
Compare
Blackhex
force-pushed
the
woarm64
branch
2 times, most recently
from
c26bfab to
266c7a4
Compare
Blackhex
force-pushed
the
fix-va-list
branch
2 times, most recently
from
e65268d to
caa9691
Compare
Blackhex
force-pushed
the
fix-va-list
branch
2 times, most recently
from
0321b24 to
d4e43b1
Compare
|
It looks like a right direction. I suggest to get CI results for the toolchain with ucrt. |
Blackhex
force-pushed
the
fix-va-list
branch
2 times, most recently
from
4049420 to
0d90f62
Compare
Blackhex
force-pushed
the
woarm64
branch
11 times, most recently
from
d8ce338 to
a591924
Compare
Blackhex
force-pushed
the
woarm64
branch
3 times, most recently
from
0f1f207 to
7b6b916
Compare
Blackhex
force-pushed
the
woarm64
branch
11 times, most recently
from
023a528 to
33bedaf
Compare
Blackhex
force-pushed
the
fix-va-list
branch
from
694bf98 to
8fcc7ae
Compare
Blackhex
changed the title
Blackhex
force-pushed
the
fix-va-list
branch
2 times, most recently
from
ec58053 to
72e8dcb
Compare
eukarpov
force-pushed
the
woarm64
branch
2 times, most recently
from
602dad8 to
b3295b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper implementation of Microsoft Arm64 variadic function call ABI.
Tests will be added within Windows-on-ARM-Experiments/mingw-woarm64-build#221
So far tested by https://github.com/Windows-on-ARM-Experiments/mingw-woarm64-build/actions/runs/12813347930
Resolves:
va_liststructure is corrupted mingw-woarm64-build#70atoi+printfdoes not work when linking withucrtmingw-woarm64-build#192 (TODO: Not verified yet.)Contributes to: