Fix setfinalizer to reject unreachable threshold values#213
Open
Fix setfinalizer to reject unreachable threshold values#213
Conversation
The bios setfinalizer action only validated that the threshold was greater than half the sum of finalizer weights, but did not check that the threshold was actually reachable (i.e. <= weight_sum). A threshold exceeding the total weight can never achieve quorum, which would permanently halt finality. Add the upper-bound check (ported from Vaulta system contracts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bios setfinalizer action only validated that the threshold was greater than half the sum of finalizer weights, but did not check that the threshold was actually reachable (i.e. <= weight_sum). A threshold exceeding the total weight can never achieve quorum, which would permanently halt finality.
Add the upper-bound check (ported from Vaulta system contracts). See VaultaFoundation/system-contracts@ea0835b