Skip to content

update instructions and remove failing linter step #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DiegoQuiros94 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update instructions and remove failing linter step #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdf1805
update instructions and remove failing linter step
Jan 6, 2022
393ba85
add TODOs
Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions KICKOFF.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@ To create a new project, you must follow these steps:

1) Clone [Wolmo’s Bootstrap project](https://github.com/Wolox/wolmo-bootstrap-react-native)

2) In case you have Cocoapods pre-installed, first update the repository with:
2) go to the cloned repository folder and run

```bash
yarn
```

3) In case you have Cocoapods pre-installed, first update the repository with:

```bash
pod repo update
```

3) Go to the folder in which you’d like your project to be in and run:
4) Go to the folder in which you’d like your project to be in and run:

```js
yo path-to-wolmo/generators/app/index.js
Expand All @@ -25,7 +31,7 @@ In case you need to debug it, you can add the `--verbose` param:
yo path-to-wolmo/generators/app/index.js --verbose
```

4) Follow the wizard
5) Follow the wizard

## Repository

Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@

- CocoaPods: https://guides.cocoapods.org/using/getting-started.html#installation
- Node: https://github.com/creationix/nvm#install-script
- React Native Environment: https://facebook.github.io/react-native/docs/getting-started.html
- Ruby (for Fastlane): https://rvm.io/rvm/install
- React Native Environment: https://archive.reactnative.dev/docs/getting-started
- Ruby (for Fastlane, RVM is recommended to avoid permission problems): https://github.com/rvm/rvm
- Yarn: https://yarnpkg.com/lang/en/docs/install/#alternatives-tab
- Yeoman: https://yeoman.io/learning/index.html

## KickOff

Expand Down
6 changes: 4 additions & 2 deletions generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ const configureIosProject = require('./tasks/installTasks/configureIosProject');
const installPods = require('./tasks/installTasks/installPods');
const linkAppAssets = require('./tasks/installTasks/linkAppAssets');
const editBundleIdentifier = require('./tasks/installTasks/editBundleIdentifier');
const lintFixProject = require('./tasks/installTasks/lintFixProject');
// TODO: Removed until linter is fixed
// const lintFixProject = require('./tasks/installTasks/lintFixProject');
const chmodFirebaseScript = require('./tasks/installTasks/chmodFirebaseScript');
const gitInitialization = require('./tasks/installTasks/gitInitialization');
// END
Expand Down Expand Up @@ -98,7 +99,8 @@ class ReactNativeBootstrap extends Generator {
.then(() => installPods.bind(this)())
.then(() => linkAppAssets.bind(this)())
.then(() => editBundleIdentifier.bind(this)())
.then(() => lintFixProject.bind(this)())
// TODO: removed until linter is fixed
// .then(() => lintFixProject.bind(this)())
.then(() => this.features.hasFirebase && chmodFirebaseScript.bind(this)())
.then(() => gitInitialization.bind(this)());
}
Expand Down