[Update] Documentation for sniff WordPress.Security.PluginMenuSlug #2592
Conversation
jrfnl
changed the title
jasonkenison
changed the title
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Thanks for working on this @jasonkenison! It is looking good. I left a few comments with suggestions to improve it.
rodrigoprimo
left a comment
rodrigoprimo
left a comment
There was a problem hiding this comment.
Thanks for your work, @jasonkenison! This is looking good.
I left just two final comments with nitpicks. Let me know if you agree or not.
|
@jasonkenison, I was just wondering if you'll have a chance to finish this off in the near future. It would be great if this PR could be included in the next WPCS release. If you haven't got time or lost interest, please let us know and we'll see if we can find someone to take over. Thanks! |
Thanks for your reply, @jasonkenison! You are correct and I missed that you had addressed all the changes already. If you can, please mark them all as resolved as I don't have permission to do it. On a final look, I noticed a minor typo in WordPress and left a comment. Could you please addressed it when you get a chance? |
There was a problem hiding this comment.
Looks good to me, @jasonkenison! Thanks for working on this PR.
3 participants
Related to #1722
Initial Docs/Security/PluginMenuSlugStandard.xml
Describes check for
__FILE__in plugin menu slugs.