Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WOFF2 from Google Fonts #509

Closed
wants to merge 2 commits into from

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented Jan 24, 2024

What?

  • Use WOFF2 format to add font faces from Google Fonts

Why?

WOFF2 is a lighter format than TTF and is compatible with most browsers.

How?

  • Update the Google Fonts API URL to get the WOFF version of the fonts.
  • Update the Google Fonts API data in the repo.

Testing instructions:

  • Go to "Add Google Fonts" section.
  • Add a few fonts to test that the woff2 fonts are added to your theme.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can successfully add Google fonts and I can see they're WOFF files, however I'm seeing the following error when I select a Google font from the dropdown:

TypeError: e.brotliDecompressSync is not a function at K

image

@vcanales
Copy link
Member

vcanales commented Apr 3, 2024

Font management is no longer a part of this plugin.

@vcanales vcanales closed this Apr 3, 2024
@vcanales vcanales deleted the add/use-woff2-from-google-fonts branch May 23, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants