Open
Conversation
|
Size Change: 0 B Total Size: 6.87 MB ℹ️ View Unchanged
|
15 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in f46ca3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22737290393
|
ciampo
reviewed
Mar 6, 2026
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
I feel like we should use the same token for other components too apart from Tabs — I can think of Button and Select, maybe input labels? (waiting for more form components to be added, such as radios / comboboxes etc)
Contributor
@mirka , Thanks for the work and discussion around this issue. I was looking into it with the intention of contributing, but it seems that addressing it properly would require a fair amount of work, including significant testing and potentially updating existing tests to avoid regressions. Since this relates to the Just wanted to check on the direction before putting in the required time and effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #75697
Part of #76221
Uses the
--wpds-cursor-controldesign token for all non-link interactive controls in the@wordpress/uipackage, and adds a stylelint rule there to prevent newcursor: pointerdeclarations from being introduced.Why?
The
--wpds-cursor-controltoken (added in #75697) allows the cursor style for interactive non-link controls to be configured via the design system. This PR adopts it in the one applicable place in@wordpress/ui(the Tabs component), and adds a lint rule so future components use the token instead of hardcodingcursor: pointer.This is the first step towards repo-wide adoption. Next will be
@wordpress/components.How?
cursor: pointerwithvar(--wpds-cursor-control)intabs/style.module.css.packages/ui/.stylelintrc.mjswith adeclaration-property-value-disallowed-listrule that flagscursor: pointer, using a custom message function to guide toward the token.stylelint-disable-next-linecomment inbutton/style.module.cssfor the&[href]selector, wherecursor: pointeris intentional (links should always use pointer).Testing Instructions
npm run storybook:devand check the Tabs stories (the token defaults todefault).cursor: pointerto any@wordpress/uiCSS file should trigger the rule.