CollapsibleCard: use Collapsible.Trigger instead of custom click handler#76265
Open
CollapsibleCard: use Collapsible.Trigger instead of custom click handler#76265
Conversation
5 tasks
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
ciampo
force-pushed
the
feat/ui-card-improvements
branch
from
4d4f343 to
75c28a2
Compare
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
added
[Type] Enhancement
|
Flaky tests detected in 75c28a2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22782233109
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #76252
Use a
Collapsible.Triggercomponent instead of a custom click handler to let end users collapse/expand the card bliclicking anywhere on the card headerWhy?
Cleaner approach, less first-party logic
How?
Using a second
Collapsible.TriggercomponentTesting Instructions
Make sure that the
CollapsibleCardcan be still expanded/collapsed by clicking anywhere on the header.