-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate use of cursor move counting from OD_HTML_Tag_Processor
#1861
base: trunk
Are you sure you want to change the base?
Conversation
OD_HTML_Tag_Processor
Restore deprecated method without using it
bc8a3f1
to
6d979f7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #1861 +/- ##
=======================================
Coverage 66.64% 66.64%
=======================================
Files 88 88
Lines 7015 7018 +3
=======================================
+ Hits 4675 4677 +2
- Misses 2340 2341 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Interestingly, the attribute order changes in one of the snapshots with the backport in place: -<video data-od-added-preload data-od-xpath="/HTML/BODY/DIV[@class='wp-site-blocks']/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>\n
+<video data-od-xpath="/HTML/BODY/DIV[@class='wp-site-blocks']/*[1][self::FIGURE]/*[1][self::DIV]/*[1][self::VIDEO]" data-od-added-preload preload="auto" src="https://example.com/video1.mp4" poster="https://example.com/poster1.jpg" width="640" height="480"></video>\n The test is passing in |
This deprecates the use of
\OD_HTML_Tag_Processor::get_cursor_move_count()
in favor of backporting an adaptation of the internal fix put in place for WP 6.8 in Core-62085.This will facilitate eventually allowing the use of
WP_HTML_Tag_Processor
instead ofWP_HTML_Tag_Processor
, which will handles all of HTML's unique parsing conditions.