Simplify backend (Define custom endpoints for blogpost subject type + foundation bits) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or storing promoted post
ashfame
force-pushed
the
simplify_backend
branch
from
a7abd9a
to
73bb863
Compare
Merged
…ules out to their own func
need to specify the phpdoc block on the test /** * @group failing */
ashfame
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the successor of #85 in which after simplifying the types, we simplify the backend by defining our own custom endpoints with flat object structures rather than fiddling with extending the existing one with more fields and some meta fields.
This way, all WordPress-y bits are abstracted away from the frontend and its contained on the PHP side. This would also remove some of the PHP code and simplifies things once the frontend switches over to use the new custom endpoints.
But before it does, we need to define the api, which is being done in #86 It would also warrant some more changes in our custom endpoints built in this PR.
Finally, since its hard to define a finish line for this PR with other changes being pending, I think just having the custom endpoints up is what I will strive to have as the goal for this PR.