Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation support #98

Draft
wants to merge 1 commit into
base: pages
Choose a base branch
from
Draft

Add navigation support #98

wants to merge 1 commit into from

Conversation

akirk
Copy link
Member

@akirk akirk commented Nov 7, 2024

This adds a navigation post type. Unfortunately currently broken with the error:

[07-Nov-2024 17:11:09 UTC] PHP Notice: Function register_post_type was called incorrectly. Post type names must be between 1 and 20 characters in length. Please see Debugging in WordPress for more information. (This message was added in version 4.2.0.) in /wordpress/wp-includes/functions.php on line 135

Screenshot 2024-11-07 at 18 07 36

@akirk akirk marked this pull request as draft November 7, 2024 17:11
@akirk akirk changed the title Add page support Add navigation support Nov 7, 2024
@ashfame
Copy link
Member

ashfame commented Nov 8, 2024

@akirk I believe you accidentally selected the target branch to your old branch (which was based on old trunk). Not to worry, I will rebase the single commit that this PR should have had & adapt it to work with latest trunk. But first we would need the navigation endpoint setup, which is a little more than blog-posts and pages endpoint.

@akirk akirk changed the base branch from add-page to pages November 8, 2024 11:19
@akirk
Copy link
Member Author

akirk commented Nov 8, 2024

Indeed thanks, I've changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants