[codex] Use progressbar for autosave progress#3817
Draft
ashfame wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This is the semantic accessibility fix for #3815. The in-progress save/autosave indicator no longer uses
role="status"as the progress surface. Instead, the indicator is exposed as arole="progressbar"with exactaria-valuenowandaria-valuetextvalues.A separate visually hidden polite status region now announces only meaningful transitions, such as save/autosave completion and failure. The visible progress ring still updates with exact progress.
The existing Playwright autosave status sampling was updated to include progressbar nodes, assert exact progress on
aria-valuetext, and assert that percent progress is no longer exposed throughrole="status".Approach
The in-progress indicator now uses:
role="progressbar"aria-label="Autosave progress"oraria-label="Save progress"aria-valuemin="0"aria-valuemax="100"aria-valuenow={progressPercent}aria-valuetext, for exampleAutosaving 42%A hidden
role="status"live region announces only completion/failure messages and skips initial render announcements.Pros
Cons
progressbarnodes.Validation
npm exec nx -- run playground-website:typechecknpm exec nx -- run playground-website:lint