-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive PartialEq for Update structs #118
Derive PartialEq for Update structs #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you will need to run ./test/test_all.sh
and commit the changes if they look correct
d5df07f
to
97a571a
Compare
Sorry forgot about that - done now and also rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change looks good to me, only really missing a entry in the CHANGELOG (forgot to include this in my message before)
also note that i currently hold off merging PRs to allow Wulf to rebase & merge his relatively big PR, unless otherwise indicated (#103 (comment))
OK this is a bit strange to require changes of the CHANGELOG with the merge request. That will conflict pretty much every time then. Normally the CHANGELOG is updated in regular intervals for releases and I do not see a point in having "unreleased" changes in the CHANGELOG (after all there is git to see those). Just my two cents on this - I will happily update the changelog in a dedicated commit if that makes things easier for you. Just let me know. |
this is normally true, but we (at least currently) dont have automated releases and later guessing on what something changed is not the best option, including forgetting to entry a change at all. also currently every PR basically conflicts with every other PR because of the generated tests already. |
To allow easy checks for "empty" updates, this change adds the PartialEq derive to the generated Update structs. This allows comparison with `Default::default()` to check if an update is empty. Fixes: Wulf#117
97a571a
to
43ea01b
Compare
To allow easy checks for "empty" updates, this change adds the PartialEq derive to the generated Update structs. This allows comparison with
Default::default()
to check if an update is empty.Fixes: #117